2
Support for consuming "Forwarded" HTTP header (RFC7239)
Source: dani-garcia/vaultwarden#3097 · opened by @dionysius
Link to RFC:
The Forwarded HTTP header quasi supersedes the technically non-standardized (de-facto standardized) X-Forwarded-* headers.
Using the Forwarded header allows to chain proxies and with it chaining those forwarded fields.
Suggestion:
If in the config the exact string Forwarded is set for IP_HEADER, vaultwarden will try to read the first (or last?) for property as the real ip.
If there really is a chain of forwarded fields, one might want to configure from which group the for field should be read from. If the new IP_FORWARDED_BY config option is set only that groups for property is consumed where by matches this fields' value.
The Forwarded HTTP header quasi supersedes the technically non-standardized (de-facto standardized) X-Forwarded-* headers.
Using the Forwarded header allows to chain proxies and with it chaining those forwarded fields.
Suggestion:
If in the config the exact string Forwarded is set for IP_HEADER, vaultwarden will try to read the first (or last?) for property as the real ip.
If there really is a chain of forwarded fields, one might want to configure from which group the for field should be read from. If the new IP_FORWARDED_BY config option is set only that groups for property is consumed where by matches this fields' value.
No pledges yet. Be the first to back this.
Comments
Similar requests
Consider `invitation_org_name` and `smtp_from_name` to be sensitive as well for `Generate Support String`
1 vote · 0 comments
Missing ForcePasswordReset on API key login responses
1 vote · 0 comments
“Can edit” becomes ”Can manage”
1 vote · 0 comments
internal web-ui support http
1 vote · 0 comments
Suggestion: Disable-HTTPS environment variable
4 votes · 0 comments
No comments yet.