2
Improve 2FA Token Missing Logging
Source: dani-garcia/vaultwarden#4613 · opened by @t0rb3n
We see a lot of
[error][ERROR] 2FA token not provided in our logs without being able to map this to a specific user.
My suggestion is to improve logging in src/api/idenitity.rs
by appending the same output as password login failed, e.g. format!("IP: {}. Username: {}.", ip.ip, username) (Copied from
So that line could become something like this:
None => err_json!(_json_err_twofactor(&twofactor_ids, &user.uuid, conn).await?, "2FA token not provided ", format!("IP: {}. Username: {}.", ip.ip, user.username)), (Not sure what properties in user exists)
[error][ERROR] 2FA token not provided in our logs without being able to map this to a specific user.
My suggestion is to improve logging in src/api/idenitity.rs
by appending the same output as password login failed, e.g. format!("IP: {}. Username: {}.", ip.ip, username) (Copied from
So that line could become something like this:
None => err_json!(_json_err_twofactor(&twofactor_ids, &user.uuid, conn).await?, "2FA token not provided ", format!("IP: {}. Username: {}.", ip.ip, user.username)), (Not sure what properties in user exists)
No pledges yet. Be the first to back this.
Comments
Similar requests
Additional configuration for hardening 2FA
2 votes · 0 comments
Disable 2FA email setup button if email 2FA is disabled in admin settings
1 vote · 0 comments
option to force periodic reauth and 2FA
4 votes · 0 comments
2FA for web extension
2 votes · 0 comments
Default 2FA email for new users invited to organizations with 2FA-policy enabled
11 votes · 0 comments
No comments yet.