1
docker_base_image is called even if running_within_docker false
Source: dani-garcia/vaultwarden#3021 · opened by @tessus
I've noticed that the support string still shows and calls docker_base_image(), even though running_within_docker is false.
The checks on the diagnostics show:
but the support string shows:
I'd like to propose either one of the 2 options (I'll create a PR, if and when there's a consensus):
• do not show (Base: Unknown), if Running within Docker: false
• read /etc/os-release, if it exists and use NAME or PRETTY_NAME as base (apart from Debian and Alpine)
@BlackDex what's your take on this? Does this make sense or am I overthinking it?
The checks on the diagnostics show:
but the support string shows:
I'd like to propose either one of the 2 options (I'll create a PR, if and when there's a consensus):
• do not show (Base: Unknown), if Running within Docker: false
• read /etc/os-release, if it exists and use NAME or PRETTY_NAME as base (apart from Debian and Alpine)
@BlackDex what's your take on this? Does this make sense or am I overthinking it?
No pledges yet. Be the first to back this.
Comments
Similar requests
My items collection is not created when enabling Enforce organization ownership
4 votes · 0 comments
Consider `invitation_org_name` and `smtp_from_name` to be sensitive as well for `Generate Support String`
1 vote · 0 comments
Missing ForcePasswordReset on API key login responses
1 vote · 0 comments
“Can edit” becomes ”Can manage”
1 vote · 0 comments
Bitwarden in Disclaimer
1 vote · 0 comments
No comments yet.