1
Modify embedded URL regex to match self-hosted domains as well
Source: outline/outline#3577 · opened by @intradeus
Wouldn't it be nice if we could embed self-hosted webapps as well ?
For example, I have a self-hosted instance of Tldraw, but the regex in the [Tldraw.tsx]( file is limited to :
"https?://www.tldraw.com/r/(.*)$"
If I create a PR that admits URLs matching new RegExp("https?://*tldraw*.*/r/(.*)$")]; , this way you could self-host 'tldraw.yourdomain.ca' and could embed it into outline, would this PR be accepted ? Or is it out of scope / brings security risks ?
The limit is that self-hosted instances would NEED to have 'tldraw', 'airtable' or else, in the domain, in order to match the regex.
For example, I have a self-hosted instance of Tldraw, but the regex in the [Tldraw.tsx]( file is limited to :
"https?://www.tldraw.com/r/(.*)$"
If I create a PR that admits URLs matching new RegExp("https?://*tldraw*.*/r/(.*)$")]; , this way you could self-host 'tldraw.yourdomain.ca' and could embed it into outline, would this PR be accepted ? Or is it out of scope / brings security risks ?
The limit is that self-hosted instances would NEED to have 'tldraw', 'airtable' or else, in the domain, in order to match the regex.
No pledges yet. Be the first to back this.
Comments
Similar requests
Add option to disable email verification check in authentication settings
3 votes · 0 comments
Shared Figma account for previews
2 votes · 0 comments
Increase Length of Embedded Docs
1 vote · 0 comments
Feature Request: Gitea / Forgejo OAuth2 & embedded links support
1 vote · 0 comments
Custom domains per collection
3 votes · 0 comments
No comments yet.