1
Better file handling in case of crash
Source: immich-app/immich#12998 · opened by @Gunni
The bug So i have been having memory problems on my host, which has causes immich to be killed by the evil OOM killer. That should not be a problem in and of itself, but it has caused immich to leave leftover 0 byte files that don't get cleaned up, and seemingly don't get detected as empty?? My suggestion is to upload files/generate thumbs/transcode video in temp files at the location where they will eventually be stored, but either using anonymous file and then naming them, or using a temporary name like .<name> that gets cleaned up on startup and then the slow operation can take however long it wants, and then the operation of renaming is atomic. It either happens or not. By doing this you never have broken or incomplete files. p.s. you can put the temp files elsewhere but rename is only atomic if it does not cross mountpoints afaik. The OS that Immich Server is running on FreeNAS Scale Version of Immich Server v1.115.0 Version of Immich…
No pledges yet. Be the first to back this.
Comments
Similar requests
[Feature] Automatically pause and resume Remote Machine Learning for on-and-off beefy machine
18 votes · 0 comments
[Feature] (Android) Support for identifying burst photos (continuous shooting)
30 votes · 0 comments
Immich fails to adapt when server address changes behind a redirect domain
1 vote · 0 comments
Proposal: Rust Sync Engine — Eliminating iOS Background Sync Failures at the Architecture Level
3 votes · 0 comments
[Feature] Ban on bulk deletion of photos and videos (or limiting the volume of deletions)
3 votes · 0 comments
No comments yet.